Add a grid pattern overlay feature to QField's QML camera #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 7fe799e: arm64-android |
domi4484
approved these changes
Nov 13, 2023
Comment on lines
+378
to
+379
| } else { | ||
| camera.flash.mode = Camera.FlashOff |
There was a problem hiding this comment.
Suggested change
| } else { | |
| camera.flash.mode = Camera.FlashOff | |
| } | |
| else if (camera.flash.mod == Camera.FlashOn) | |
| camera.flash.mode = Camera.FlashAuto; | |
| } else { | |
| camera.flash.mode = Camera.FlashOff; |
Otherwise I can't find where the FlashAuto mode is set
There was a problem hiding this comment.
@domi4484 , the idea here was to only allow for On/Off, hence why Auto isn't set. We can tweak in a separate PR if that's something you feel is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a grid overlay to QField's QML {still,video} camera. I've always found such a functionality super useful when trying to take technical photos. The overlay can be turned on/off via an overlay button located at the top left corner of the screen.
Screenshot time:
With that in, as well as the recent geotagging functionality, I'm wondering whether we should switch the default camera back to the QML camera. People have reported the memory saturation crash gone when using the QML camera. Food for thoughts.
(Edit: forgot to mention the commit also fixes an issue with the capture/record button overlapping the system's bottom margin within which we shouldn't have anything interactive)