Move from QModelIndex to QPersistentModelIndex in the layer tree proxy model class #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for c37cef7: arm64-android |
|
Do we also want to check for validity as advised in the docs? |
suricactus
reviewed
Nov 2, 2023
There was a problem hiding this comment.
According to the docs, the QPersistentModelIndex is the way to go anyways.
There is this important bit of info from the docs here, I think this might improve the situation with random crashes:
It is good practice to check that persistent model indexes are valid before using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix this (https://opengisch.sentry.io/issues/4569883968/?project=6119013&query=is%3Aunresolved&referrer=issue-stream&sort=user&statsPeriod=7d&stream_index=10) which has been a longstanding crasher, but appears to be more frequent in Qt6.
The stacktrace is really unhelpful, but it does tell us that FlatLayerTreeModelBase::data's check for a valid source model QModelIndex doesn't appear to be enough.
I think moving from a
QList<QModelIndex>to aQList<QPersistentModelIndex>could improve things here.