Fix CI warnings

opengisch · Nov 24, 2024 · a81f884 · a81f884
1 parent 3ddd1ac
commit a81f884
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/locator/qfieldlocatorfilter.cpp b/src/core/locator/qfieldlocatorfilter.cpp
@@ -117,10 +117,10 @@ void QFieldLocatorFilter::prepareResult( const QVariant &details )
   result.group = detailsMap.value( QStringLiteral( "group" ), QString() ).toString();
   result.groupScore = detailsMap.value( QStringLiteral( "groupScore" ), 0.5 ).toDouble();
   const QVariantList actions = detailsMap.value( QStringLiteral( "actions" ) ).toList();
-  for ( const QVariant action : actions )
+  for ( const QVariant &action : actions )
   {
     const QVariantMap actionMap = action.toMap();
-    result.actions << QgsLocatorResult::ResultAction( actionMap.value( "id", 0 ).toInt(), actionMap.value( "name", QString() ).toString(), actionMap.value( "icon", QString() ).toString() );
+    result.actions << QgsLocatorResult::ResultAction( actionMap.value( QStringLiteral( "id" ), 0 ).toInt(), actionMap.value( QStringLiteral( "name" ), QString() ).toString(), actionMap.value( QStringLiteral( "icon" ), QString() ).toString() );
   }
   emit resultFetched( result );
 }

diff --git a/src/qml/LocatorSettings.qml b/src/qml/LocatorSettings.qml
@@ -96,7 +96,7 @@ Popup {
               indicator.implicitHeight: 24
               indicator.implicitWidth: 24
               checked: Default ? true : false
-              onCheckedChanged: Default = checked
+              onClicked: Default = checked
             }
           }
         }