Skip to content

Commit

Permalink
🔧(demo) Allow setting demo site domain so it is not localhost:8080
Browse files Browse the repository at this point in the history
On our demo site, the site domain always ended-up as localhost:8080.
It was because we override it with a default value while building
the demo site.
  • Loading branch information
sampaccoud committed Jun 2, 2021
1 parent 6ad740b commit f327573
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions sites/demo/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

### Fixed

- Allow setting demo site domain otherwise so it is not set to localhost:8080

## [1.11.0] - 2021-05-03

### Changed
Expand Down
4 changes: 3 additions & 1 deletion sites/demo/src/backend/demo/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,9 @@ class Base(StyleguideMixin, DRFMixin, RichieCoursesConfigurationMixin, Configura
}

# Demo
RICHIE_DEMO_SITE_DOMAIN = "localhost:8080"
RICHIE_DEMO_SITE_DOMAIN = values.Value(
default="localhost:8080", environ_name="RICHIE_DEMO_SITE_DOMAIN", environ_prefix=None
)
RICHIE_DEMO_FIXTURES_DIR = os.path.join(BASE_DIR, "base", "fixtures")

# Elasticsearch
Expand Down

0 comments on commit f327573

Please sign in to comment.