-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly and conda CI #1965
Merged
Fix nightly and conda CI #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
j-wags
commented
Nov 13, 2024
•
edited
Loading
edited
- Fixes A freesolv GBSA energy test is failing on mac-latest CI #1964 by forcing use of the reference platform
- Skip parmed-requiring example in conda tests since we can't build an env with parmed 3, rdkit 2024, and OFFTK 0.16.6 (see ParmEd 4 breaks examples #1532)
- Update nagl tests to use a molecule that raises the bad bond error with nagl 0.5
- Downpin conda tests to use nagl 0.4 until the next release
- Disable slow tests before merging
Testing skipping external examples in conda tests here https://github.com/openforcefield/openff-toolkit/actions/runs/11821663944 |
The test still fails with openmm 8.1, so openmm 8.2 isn't the problem. |
Oh wow, forcing the reference platform on ARM macs seemed to solve the GBSA energy issue. |
New conda tests dispatched here https://github.com/openforcefield/openff-toolkit/actions/runs/11827917748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.