Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly and conda CI #1965

Merged
merged 12 commits into from
Nov 14, 2024
Merged

Fix nightly and conda CI #1965

merged 12 commits into from
Nov 14, 2024

Conversation

j-wags
Copy link
Member

@j-wags j-wags commented Nov 13, 2024

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (8aa96bc) to head (9194001).
Report is 1 commits behind head on main.

Additional details and impacted files

@j-wags j-wags changed the title Fix gbsa test by relaxing tolerance Fix nightly and conda CI Nov 13, 2024
@j-wags
Copy link
Member Author

j-wags commented Nov 13, 2024

Testing skipping external examples in conda tests here https://github.com/openforcefield/openff-toolkit/actions/runs/11821663944

@j-wags
Copy link
Member Author

j-wags commented Nov 13, 2024

The test still fails with openmm 8.1, so openmm 8.2 isn't the problem.

@j-wags
Copy link
Member Author

j-wags commented Nov 13, 2024

Oh wow, forcing the reference platform on ARM macs seemed to solve the GBSA energy issue.

@j-wags
Copy link
Member Author

j-wags commented Nov 13, 2024

@j-wags j-wags merged commit 3d84c70 into main Nov 14, 2024
18 checks passed
@j-wags j-wags deleted the fix-ci branch November 14, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A freesolv GBSA energy test is failing on mac-latest CI
1 participant