Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interchange 0.4 in tests #1956

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Use interchange 0.4 in tests #1956

merged 9 commits into from
Nov 5, 2024

Conversation

mattwthompson
Copy link
Member

No description provided.

Updates for Interchange 0.4.0/Pydantic v2

Update BRD4 notebook

cosmetic commit to kick CI

Revert
# This is the 1st commit message:

Test against `openff-interchange-0.4.0beta1`

Updates for Interchange 0.4.0/Pydantic v2

Update BRD4 notebook

cosmetic commit to kick CI

Revert

# This is the commit message #2:

Test against branch

# This is the commit message #3:

Undo change

# This is the commit message #4:

Revert some changes for simpler diff

# This is the commit message #5:

Another simplification

# This is the commit message #6:

Simplify
Update BRD4 notebook

cosmetic commit to kick CI

Revert

Test against branch

Undo change

Revert some changes for simpler diff

Another simplification

Simplify

Test against `openff-interchange-0.4.0beta1`

Updates for Interchange 0.4.0/Pydantic v2

Update BRD4 notebook

cosmetic commit to kick CI

Revert

Revert some changes for simpler diff

Another simplification

Bump version
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (6aa989e) to head (707b94b).
Report is 3 commits behind head on main.

Additional details and impacted files

@mattwthompson mattwthompson marked this pull request as ready for review November 4, 2024 20:33
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @mattwthompson!

@mattwthompson mattwthompson merged commit c4ec601 into main Nov 5, 2024
18 checks passed
@mattwthompson mattwthompson deleted the test-interchange-0.4 branch November 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants