-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: taxonomy patch instead of re-generating #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to do some testing ! |
I did a test openfoodfacts-bot/openfoodfacts-server#61 it results there are still some bugs that I have to solve. The most problematic is if we change entry id. I think that along the entry last modification timestamp, I will also store the modified attributes, so that I know if entry id was modified. |
to account for new entry placements with patcher
alexgarel
force-pushed
the
feat-taxonomy-patch
branch
from
December 17, 2024 17:31
34c3604
to
f0b4c43
Compare
node removal mark was not the right one
This was referenced Dec 20, 2024
alexgarel
added a commit
that referenced
this pull request
Dec 20, 2024
## [1.2.0](v1.1.0...v1.2.0) (2024-12-20) ### Features * first beauty and product taxonomies ([#559](#559)) ([e66db34](e66db34)) * more readable default project names ([#557](#557)) ([4036188](4036188)) * taxonomy patch instead of re-generating ([#554](#554)) ([928dfd0](928dfd0)) ### Bug Fixes * bad tables dom on errors and search results ([#556](#556)) ([31243c7](31243c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Alex Garel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be able to patch taxonomy text files instead of re-generating them completely.
This will avoid having a lot of changes that are not related to the real modifications made by a contributor.
For this we need to
Relates to: #541 and #366
TODO:
add sort on modified parameter in search(sort is not done at all, for now)