Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimized version of the scan cards for small screens #5928

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 25, 2024

Hi everyone!

On small screens (particularly on Android with the old nav bar), the scan cards were cropped.
Everything is now fixed:
Cards

Improvement 1: close icon for errors

When there is an error, it's now possible to remove the card:
IMG_5A877BCB3A43-1

Improvement 2: the orange is now animated

And you can click on it to restart the animation!

🎥 https://github.com/user-attachments/assets/b25e4e40-7e65-44ef-bfe6-c35a5f0f729d
The Rive file is also optimized by removing unused animations (-31ko 🏋️‍♂️)

Improvement 3: slide up transition for the product page

There is now a slide up transition (the same one as in Android P), when the product page is opened from the carousel:

🎥 https://github.com/user-attachments/assets/5d3910b0-09b0-4ac6-9a2b-2d7bfe2371a8

@g123k g123k linked an issue Nov 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… product scan carousel labels Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0.69930% with 142 lines in your changes missing coverage. Please review.

Project coverage is 6.57%. Comparing base (4d9c7fc) to head (6497ba9).
Report is 514 commits behind head on develop.

Files with missing lines Patch % Lines
...h_app/lib/pages/navigator/slide_up_transition.dart 0.00% 64 Missing ⚠️
...kages/smooth_app/lib/resources/app_animations.dart 2.77% 35 Missing ⚠️
.../cards/product_cards/smooth_product_base_card.dart 0.00% 14 Missing ⚠️
.../smooth_app/lib/pages/navigator/app_navigator.dart 0.00% 12 Missing ⚠️
...oth_app/lib/pages/scan/carousel/scan_carousel.dart 0.00% 7 Missing ⚠️
...cards/product_cards/smooth_product_card_error.dart 0.00% 4 Missing ⚠️
...s/product_cards/smooth_product_card_not_found.dart 0.00% 3 Missing ⚠️
...pages/product/product_page/new_product_header.dart 0.00% 2 Missing ⚠️
...ib/pages/scan/carousel/main_card/scan_tagline.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5928      +/-   ##
==========================================
- Coverage     9.54%   6.57%   -2.97%     
==========================================
  Files          325     437     +112     
  Lines        16411   24666    +8255     
==========================================
+ Hits          1567    1623      +56     
- Misses       14844   23043    +8199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Nov 25, 2024
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g123k 😊

@teolemon teolemon merged commit c8d5392 into openfoodfacts:develop Nov 25, 2024
7 of 8 checks passed
@g123k g123k deleted the scan_cards_small_screens branch November 25, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🥫 Product page product scan carousel router 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging this pull request may close these issues.

Scan cards in the carousel need optimisations on small screens
3 participants