feat: added the "Help improve OFF in your country" tile on the contribute page #5510

jnnabugwu · 2024-07-23T22:37:23Z

What

Added the help improve OFF in your country tile on the contribution page.

Screenshot

Fixes bug(s)

Closes: Create a "Contribute to your country" link #5467

monsieurtanuki

Hi @jnnabugwu!
That's good but there are still things to address. Please read my comments for details.

monsieurtanuki · 2024-07-24T05:17:31Z

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

+            () async => LaunchUrlHelper.launchURL(
+                'https://wiki.openfoodfacts.org/Country_Support_- ${userPreferences.userCountryCode ?? 'France'}'),
+            const IconData(0xf68d),
+            externalLink: true),


Suggested change

externalLink: true),

externalLink: true,),

It's not really optional.

monsieurtanuki · 2024-07-24T05:21:14Z

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

+            'Help improve Open Food Facts in your country',
+            () async => LaunchUrlHelper.launchURL(
+                'https://wiki.openfoodfacts.org/Country_Support_- ${userPreferences.userCountryCode ?? 'France'}'),
+            const IconData(0xf68d),


There's a globe icon you should reuse: the one used in the app country selector.

You're right ill look

monsieurtanuki · 2024-07-24T05:24:57Z

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

+        _getListTile(
+            'Help improve Open Food Facts in your country',
+            () async => LaunchUrlHelper.launchURL(
+                'https://wiki.openfoodfacts.org/Country_Support_- ${userPreferences.userCountryCode ?? 'France'}'),


It's not the way it works:

you need to maintain a Map of country/wiki-link, as stated in the issue, for the same limited list of countries, with the correct values

if the current country is not in the Map, you mustn't display that ListTile.

Okay will do

packages/smooth_app/lib/l10n/app_en.arb

codecov-commenter · 2024-07-24T05:32:01Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 7.05%. Comparing base (4d9c7fc) to head (03ac3dc).
Report is 267 commits behind head on develop.

Files	Patch %	Lines
...pages/preferences/user_preferences_contribute.dart	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #5510      +/-   ##
==========================================
- Coverage     9.54%   7.05%   -2.50%     
==========================================
  Files          325     397      +72     
  Lines        16411   20889    +4478     
==========================================
- Hits          1567    1473      -94     
- Misses       14844   19416    +4572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

monsieurtanuki

Hi @jnnabugwu!
Please have a look at my comments, and never forget to format the code.

monsieurtanuki · 2024-08-01T15:59:32Z

packages/smooth_app/lib/pages/product/common/country_wiki_links.dart

@@ -0,0 +1,25 @@
+class CountryWikiLinks {


Please call it something like TmpCountryWikiLinks, and add a TODO saying that the code is to be moved to openfoodfacts-dart.

Will do. Also why am i adding the TODO saying the code will be moved to openfoodfacts-dart?

Also why am i adding the TODO saying the code will be moved to openfoodfacts-dart?

Because part of the code (in our case, the map) will eventually be moved to openfoodfacts-dart.
When we code for Smoothie, we sometimes code things that can be reused by other openfoodfacts-dart users.

monsieurtanuki · 2024-08-01T16:01:43Z

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

        ),
-        _getListTile(
+       if(CountryWikiLinks().wikiLinks.containsKey(userPreferences.userCountryCode))


Would be better to put the wiki link in a String? variable before, and then to test if (wikiLinks != null)

Let me see if I understand are you saying put the TmpCountryWikiLinks()
.wikiLinks
.containsKey(userPreferences.userCountryCode) in a variable and test if this is going to be null

If so how would that be better? Trying to learn best coding practices :)

It's typically considered a best practice to avoid a code copy/paste.
Easier to maintain, easier to read, easier to understand.

Where would I put the code because if I put it around line 57 it says userPreferences can't be accessed

I'm sure you can put TmpCountryWikiLinks() .wikiLinks[userPreferences.userCountryCode] in a local String? variable.
If needed, have a look at tutorials specific to dart or flutter, for instance about the ways a method can return a value - something like => and return syntaxes.

monsieurtanuki · 2024-08-01T16:02:13Z

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

+            () async => LaunchUrlHelper.launchURL(
+                'https://wiki.openfoodfacts.org/Country_Support_- ${userPreferences.userCountryCode ?? 'France'}'),
+            const IconData(0xf68d),
+            externalLink: true),


It's not really optional.

monsieurtanuki · 2024-08-01T16:05:30Z

packages/smooth_app/lib/pages/product/common/country_wiki_links.dart

+      // 'Belgium': 'https://wiki.openfoodfacts.org/Country_Support_-_Belgium',
+      // 'Bulgaria': 'https://wiki.openfoodfacts.org/Local_Communities/BulgarianTeam',


Please don't put useless comments.

I have harmonized on the first pattern FYI

packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart

jnnabugwu · 2024-08-08T01:46:41Z

@monsieurtanuki hey I was wondering what's the technical reason why we are using a map instead of just using strings is it just for organizing?

monsieurtanuki · 2024-08-08T07:02:30Z

@monsieurtanuki hey I was wondering what's the technical reason why we are using a map instead of just using strings is it just for organizing?

I have no idea what you mean with "just using strings". Please use a Map for the moment: that's specifically something that would be refactored in openfoodfacts-dart anyway.

teolemon · 2024-08-16T19:56:44Z

/lint

teolemon · 2024-08-16T19:59:42Z

/lint

monsieurtanuki · 2024-09-12T14:17:39Z

@jnnabugwu Still working on it?

jnnabugwu · 2024-09-13T14:06:33Z

Sorry I’ve been wrapping up in preparing for interviews

…

On Thu, Sep 12, 2024 at 10:18 monsieurtanuki ***@***.***> wrote: @jnnabugwu <https://github.com/jnnabugwu> Still working on it? — Reply to this email directly, view it on GitHub <#5510 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH3LYQZVAG3O7HD2SF6W6GDZWGPBVAVCNFSM6AAAAABLLJ32ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGQZTCNJVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

monsieurtanuki · 2024-09-13T14:10:35Z

@jnnabugwu No problem!

jnnabugwu requested a review from a team as a code owner July 23, 2024 22:37

github-actions bot assigned jnnabugwu Jul 23, 2024

monsieurtanuki reviewed Jul 24, 2024

View reviewed changes

packages/smooth_app/lib/l10n/app_en.arb Outdated Show resolved Hide resolved

monsieurtanuki changed the title ~~feat: added the help improve OFF in your country tile on the contribu…~~ feat: added the help improve OFF in your country tile on the contribute page Jul 24, 2024

teolemon added ✨ enhancement New feature or request ✏️ Contribution labels Aug 1, 2024

teolemon changed the title ~~feat: added the help improve OFF in your country tile on the contribute page~~ feat: added the "Help improve OFF in your country" tile on the contribute page Aug 1, 2024

github-actions bot added the 🥫 Product page label Aug 1, 2024

monsieurtanuki reviewed Aug 1, 2024

View reviewed changes

teolemon requested a review from a team September 20, 2024 14:43

github-actions bot added the PR: needs rebase label Oct 25, 2024

jnnabugwu closed this Nov 7, 2024

jnnabugwu force-pushed the contribute-to-your-country-link branch from b82769a to e3fa4f4 Compare November 7, 2024 03:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added the "Help improve OFF in your country" tile on the contribute page #5510

feat: added the "Help improve OFF in your country" tile on the contribute page #5510

jnnabugwu commented Jul 23, 2024 •

edited by monsieurtanuki

Loading

monsieurtanuki left a comment

monsieurtanuki Jul 24, 2024

monsieurtanuki Aug 1, 2024

monsieurtanuki Jul 24, 2024

jnnabugwu Jul 24, 2024

monsieurtanuki Jul 24, 2024

jnnabugwu Jul 24, 2024

codecov-commenter commented Jul 24, 2024 •

edited

Loading

monsieurtanuki left a comment

monsieurtanuki Aug 1, 2024

jnnabugwu Aug 5, 2024

monsieurtanuki Aug 5, 2024

jnnabugwu Aug 5, 2024

monsieurtanuki Aug 1, 2024

jnnabugwu Aug 5, 2024

jnnabugwu Aug 5, 2024

jnnabugwu Aug 5, 2024

monsieurtanuki Aug 5, 2024

jnnabugwu Aug 5, 2024

monsieurtanuki Aug 6, 2024

monsieurtanuki Aug 1, 2024

monsieurtanuki Aug 1, 2024

teolemon Aug 6, 2024

jnnabugwu commented Aug 8, 2024

monsieurtanuki commented Aug 8, 2024

teolemon commented Aug 16, 2024

teolemon commented Aug 16, 2024

monsieurtanuki commented Sep 12, 2024

jnnabugwu commented Sep 13, 2024 via email

monsieurtanuki commented Sep 13, 2024

		// 'Belgium': 'https://wiki.openfoodfacts.org/Country_Support_-_Belgium',
		// 'Bulgaria': 'https://wiki.openfoodfacts.org/Local_Communities/BulgarianTeam',

feat: added the "Help improve OFF in your country" tile on the contribute page #5510

feat: added the "Help improve OFF in your country" tile on the contribute page #5510

Conversation

jnnabugwu commented Jul 23, 2024 • edited by monsieurtanuki Loading

What

Screenshot

Fixes bug(s)

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 24, 2024 • edited Loading

Codecov Report

monsieurtanuki left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnnabugwu commented Aug 8, 2024

monsieurtanuki commented Aug 8, 2024

teolemon commented Aug 16, 2024

teolemon commented Aug 16, 2024

monsieurtanuki commented Sep 12, 2024

jnnabugwu commented Sep 13, 2024 via email

monsieurtanuki commented Sep 13, 2024

jnnabugwu commented Jul 23, 2024 •

edited by monsieurtanuki

Loading

codecov-commenter commented Jul 24, 2024 •

edited

Loading