fix: A part of the app forced to clear the model… #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🤳🥫 Scan
Codecov Report
@@ Coverage Diff @@
## develop #4517 +/- ##
========================================
Coverage 10.32% 10.32%
========================================
Files 296 296
Lines 15296 15290 -6
========================================
Hits 1579 1579
+ Misses 13717 13711 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
approved these changes
Aug 13, 2023
|
I just realized it's a full fix. Thank you so much @g123k |
|
Going to deploy it to internal now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I don't really understand what this part of the app was for… but it was continuously clearing the model.
Without it, it will fix #4507