Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4466 - icons for list page popup items #4515

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Now the popup items have a similar display.
  • More specifically, icons have been added to menu popup items.

Screenshot

before after (light) after (dark)
Screenshot_2023-08-12-18-42-19 Screenshot_2023-08-12-18-43-41 Screenshot_2023-08-12-18-44-08

Fixes bug(s)

@codecov-commenter
Copy link

Codecov Report

Merging #4515 (d4ed349) into develop (439aeb4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4515      +/-   ##
===========================================
- Coverage    10.32%   10.32%   -0.01%     
===========================================
  Files          296      296              
  Lines        15296    15298       +2     
===========================================
  Hits          1579     1579              
- Misses       13717    13719       +2     
Files Changed Coverage Δ
...pages/product/common/product_list_popup_items.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@monsieurtanuki
Copy link
Contributor Author

Thank you @g123k for your review.

As far as I'm concerned, this PR can be merged. Not sure though because it's Monday.

@teolemon teolemon merged commit 214be11 into openfoodfacts:develop Aug 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Similar menus are not coherent
4 participants