feat: 4041 - renamed "history" bottom item as "lists", w/ access to other lists

[monsieurtanuki]

What

• The "history" bottom navigation bar item is now renamed as "lists", with a different icon.
• From the product list page, we can go the other lists. For the moment, the other lists are among "scan session", "scan history" and "history".
• In a next PR, user lists will be added.

Screenshots

history page	history page with popup menu

scan history page	scan session page

Part of

• Defragment the history/list experience #4041

Files

New file:

• product_list_popup_items.dart: Popup menu items for the product list page.

Impacted files:

• app_en.arb: added 2 labels
• page_manager.dart: new label and icon for bottom bar
• product_list_page.dart: added fast access to scan session, scan history and history; moved code to product_list_popup_items.dart
• product_query_page_helper.dart: minor refactoring
• scan_header.dart: minor refactoring
• tab_navigator.dart: minor refactoring
• user_preferences_account.dart: minor refactoring

[codecov-commenter]

Codecov Report

Merging #4277 (7150c12) into develop (a5fb0e1) will decrease coverage by 0.02%.
The diff coverage is 2.46%.

@@             Coverage Diff             @@
##           develop    #4277      +/-   ##
===========================================
- Coverage    10.82%   10.80%   -0.02%     
===========================================
  Files          286      287       +1     
  Lines        14247    14273      +26     
===========================================
  Hits          1542     1542              
- Misses       12705    12731      +26     

Impacted Files	Coverage Δ
packages/smooth_app/lib/pages/page_manager.dart	0.00% <0.00%> (ø)
...pp/lib/pages/product/common/product_list_page.dart	0.00% <0.00%> (ø)
...pages/product/common/product_list_popup_items.dart	0.00% <0.00%> (ø)
...ages/product/common/product_query_page_helper.dart	27.08% <ø> (-1.49%)	⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart	0.00% <ø> (ø)
packages/smooth_app/lib/widgets/tab_navigator.dart	0.00% <0.00%> (ø)
...ib/pages/preferences/user_preferences_account.dart	62.29% <100.00%> (+0.20%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[g123k]

Hi @monsieurtanuki!

Thanks a lot for your PR. Generally speaking in terms of code, that looks OK.

But after trying your implementation on a device, I'm not convinced about the UX.
Having a Lists item in the bottom bar is OK, but it's confusing that when clicking on it, we have a History App Bar label.
A simple fix could be, to change the title to: Lists: My history or something like that.

The menu is also confusing because we mix external actions (eg: Share / View on the web) and direct actions on the list.

Here are my suggestions:

• Keep Share and View on the web in the hidden menu
• Create a dedicated icon in the AppBar to switch between lists (there is no icon for that, but I can create a custom one, which would like this one, but with a list)
• Create a dedicated Clear your history button (with the delete_sweep icon).

What do you think of this change?

[monsieurtanuki]

A simple fix could be, to change the title to: Lists: My history or something like that.

I would put the most important thing first, like History (list), but I get the idea.

The menu is also confusing because we mix external actions (eg: Share / View on the web) and direct actions on the list.

That's the general idea of a menu, and that's why they usually put separators.

Keep Share and View on the web in the hidden menu

Understood.

Create a dedicated icon in the AppBar to switch between lists (there is no icon for that, but I can create a custom one, which would like this one, but with a list)

I don't believe in custom icons.

Create a dedicated Clear your history button (with the delete_sweep icon).

I don't want to overload the app bar with buttons (I have a small screen, remember). Btw the label is incorrect: we clear whatever list (not just history).

To summarize:

• we can change the title of the app bar in order to introduce explicitly the label "list"
• we may split in two the menu actions
  • one "more" button with the actions on that list (rename, clear, share, view in web, ...)
  • one "other list" button

@g123k What do you think of those improvements?

[g123k]

After thinking a little bit, here is what it could look like, with a separation between generic actions and a switch between lists:

We change the title as suggested + we have a dedicated icon to switch between lists (the icon is incorrect here)

The menu is now simplified (icons are not mandatory, it was just a test):

And the item to switch between lists also allows creating a new one and having the custom ones also.

This would allow removing the entry from the Profile.

EDIT: The menu containing lists could be a bottom sheet also

[monsieurtanuki]

full page	"..." menu	list icon

Using a standard cupertino icon and the standard cupertino bottom sheet.

[g123k]

full page "..." menu list icon

Using a standard cupertino icon and the standard cupertino bottom sheet.

I love the change.
But why do you use a Cupertino Widget for this?
As part of #4281, there is now a SmoothModalSheet, which could be perfect here:

[monsieurtanuki]

@g123k I've just pushed a code that should be OK for you.
I'm really not convinced by the additional " (liste)" label, which looks very redundant with the navigation tab label and with the app bar icon.
Please confirm that you prefer it and I'll localize it.

full page	"..." menu	list icon

[g123k]

@g123k I've just pushed a code that should be OK for you. I'm really not convinced by the additional " (liste)" label, which looks very redundant with the navigation tab label and with the app bar icon. Please confirm that you prefer it and I'll localize it.

full page "..." menu list icon

Yes indeed, you're right, it's a bit awkward. I will think about a better solution.
For the Modal Sheet, I will probably test of few UI, as I'm not really fan of buttons, but keep it like so, it's a good start 👍

[monsieurtanuki]

I've just removed the " (liste)"label.

[g123k]

Thanks a lot for your work @monsieurtanuki

[monsieurtanuki]

Thank you @g123k for your review!
The next part (with user lists) is less trivial, as we need a refreshed list of user lists, which is refreshed async.