chore: user authentication page testing

[abughalib]

What

Golden test for Authentication Pages.

Comments

• tooltip message localization
• Sign Up Page
• Login Page
• Forgot Password Page

Part of

#1176

[codecov-commenter]

Codecov Report

Merging #3233 (e2222b6) into develop (a3608be) will increase coverage by 2.39%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3233      +/-   ##
===========================================
+ Coverage     7.69%   10.08%   +2.39%     
===========================================
  Files          249      249              
  Lines        12248    12251       +3     
===========================================
+ Hits           942     1236     +294     
+ Misses       11306    11015     -291     

Impacted Files	Coverage Δ
...ib/pages/preferences/user_preferences_account.dart	20.97% <ø> (ø)
...ib/generic_lib/widgets/smooth_text_form_field.dart	87.17% <100.00%> (+87.17%)	⬆️
...th_app/lib/pages/user_management/sign_up_page.dart	52.96% <100.00%> (+52.50%)	⬆️
...ckages/smooth_app/lib/widgets/smooth_scaffold.dart	67.79% <0.00%> (+23.72%)	⬆️
...ib/pages/user_management/forgot_password_page.dart	67.10% <0.00%> (+65.78%)	⬆️
...ooth_app/lib/pages/user_management/login_page.dart	67.21% <0.00%> (+66.39%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[monsieurtanuki]

Hi @abughalib!
Please have a look at my comments.
Beyond that, I cannot picture the Tooltip(child: InkWell...) combination: who wins if you tap?

[abughalib]

@monsieurtanuki
I had to add a label to pass labeledTapTargetGuideline or I was getting Expected: Tappable widgets should have a semantic label on golden tests.
I had two options either ignore that guideline or add a label to every onTap widget.
If you got any other idea, I would implement that.

[AshAman999]

Well just some more suggestions besides what was already suggested

Also, the pages are not entirely rendered like the bottom screen is cropped,
perhaps you can also fix that. I remember there were some scroll features in the testing library as well

[monsieurtanuki]

I had to add a label to pass labeledTapTargetGuideline or I was getting Expected: Tappable widgets should have a semantic label on golden tests.
I had two options either ignore that guideline or add a label to every onTap widget.
If you got any other idea, I would implement that.

What about Semantics(label: 'xxx', child: InkWell(...))? Or better, putting directly a semanticLabel, e.g. to Icon or TextSpan?

[abughalib]

Well just some more suggestions besides what was already suggested

Also, the pages are not entirely rendered like the bottom screen is cropped, perhaps you can also fix that. I remember there were some scroll features in the testing library as well

How to generate golden files for that?
I used flutter test --update-goldens

[AshAman999]

Looks okay to me

[M123-dev]

Heyy @abughalib looks great, just one little comment

[AshAman999]

LGTM as well