Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1698 - layout page analytics #1802

Merged
merged 3 commits into from
May 12, 2022

Conversation

cli1005
Copy link
Contributor

@cli1005 cli1005 commented May 10, 2022

What

  • The analytics screen still has a bad layout
  • The analytics screen has a different font
  • The analytics screen has an illustration that looks out of place, compared with the Knowledge panels the users has just seen before (filled, vs outline)

Screenshot

Simulator Screen Shot - iPhone 13 - 2022-05-10 at 12 08 17

Fixes bug(s)

Part of

@cli1005 cli1005 requested a review from a team as a code owner May 10, 2022 11:22
@teolemon
Copy link
Member

looks good to me @cli1005 👍

@cli1005 cli1005 requested a review from g123k May 11, 2022 09:24
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cli1005

const Icon(
Icons.close_rounded,
),
false),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for syntax, could you add an extra comma please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const Icon(
Icons.check_rounded,
),
true),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for syntax, could you add an extra comma please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #1802 (131ad95) into develop (2ea0da3) will decrease coverage by 2.22%.
The diff coverage is 2.59%.

@@            Coverage Diff             @@
##           develop   #1802      +/-   ##
==========================================
- Coverage     8.86%   6.63%   -2.23%     
==========================================
  Files          161     172      +11     
  Lines         6623    7792    +1169     
==========================================
- Hits           587     517      -70     
- Misses        6036    7275    +1239     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c02c3...131ad95. Read the comment docs.

@g123k g123k merged commit e135c19 into openfoodfacts:develop May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants