-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1698 - layout page analytics #1802
fix: #1698 - layout page analytics #1802
Conversation
looks good to me @cli1005 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @cli1005
const Icon( | ||
Icons.close_rounded, | ||
), | ||
false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for syntax, could you add an extra comma please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
const Icon( | ||
Icons.check_rounded, | ||
), | ||
true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for syntax, could you add an extra comma please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Codecov Report
@@ Coverage Diff @@
## develop #1802 +/- ##
==========================================
- Coverage 8.86% 6.63% -2.23%
==========================================
Files 161 172 +11
Lines 6623 7792 +1169
==========================================
- Hits 587 517 -70
- Misses 6036 7275 +1239
Continue to review full report at Codecov.
|
What
Screenshot
Fixes bug(s)
Part of