Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Changed the display hint name #1366

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix: Changed the display hint name #1366

merged 1 commit into from
Mar 28, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR include the hint name changed to "Name" from "Display Name"

Screenshot

Before After

Fixes bug(s)

Part of

@abhay1821 abhay1821 requested a review from a team as a code owner March 28, 2022 14:10
@abhay1821
Copy link
Contributor Author

Hi, @teolemon @M123-dev Changed the hint name could You please review it. Or if any other changes required do let me know.

@teolemon teolemon linked an issue Mar 28, 2022 that may be closed by this pull request
(Signup) no explication about the difference between username and display name #1297
Closed
M123-dev
M123-dev approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @abhay1821

@M123-dev M123-dev merged commit 7e5f0b8 into openfoodfacts:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Signup) no explication about the difference between username and display name
2 participants
@abhay1821 @M123-dev