Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The analytics screen still has a bad layout, a different font, and the illustration looks out of place, compared with the Knowledge panels the users has just seen before #1698

Closed
teolemon opened this issue Apr 29, 2022 · 3 comments · Fixed by #1802
Closed

The analytics screen still has a bad layout, a different font, and the illustration looks out of place, compared with the Knowledge panels the users has just seen before #1698

teolemon opened this issue Apr 29, 2022 · 3 comments · Fixed by #1802
Assignees
@cli1005
Labels
🎨 Mockup required 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎯 P1
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Apr 29, 2022 •
edited
Loading

What

  • The analytics screen still has a bad layout
  • The analytics screen has a different font
  • The analytics screen has an illustration that looks out of place, compared with the Knowledge panels the users has just seen before (filled, vs outline)

Screenshot

Screenshot_20220429-230001.png

Part of
@teolemon teolemon added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Apr 29, 2022
@teolemon teolemon added this to the V1 milestone May 4, 2022
@bhattabhi013
Copy link
Contributor

Hi @teolemon,
Do we have a mockup for this screen?

@bhattabhi013 bhattabhi013 mentioned this issue May 5, 2022
Closed
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 9, 2022
@teolemon
Copy link
Member Author

@cli1005 is now assigned.
Here's what v1 looked like:
image
We’re using the standards analytics icon in v1 https://materialui.co/icon/analytics

@cli1005 cli1005 moved this from Todo (ready 2 dev) to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 10, 2022
@cli1005
Copy link
Contributor

cli1005 commented May 10, 2022 •
edited
Loading

Here is a snapshot of result, please let me know if it is ok:

Simulator Screen Shot - iPhone 13 - 2022-05-10 at 12 08 17

cli1005 added a commit to cli1005/smooth-app that referenced this issue May 10, 2022
@cli1005
fix: openfoodfacts#1698 - layout page analytics
fb1e560
@cli1005 cli1005 mentioned this issue May 10, 2022
Merged
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 10, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue May 11, 2022
@cli1005
fix: openfoodfacts#1698 - refactoring code review
612864d
cli1005 added a commit to cli1005/smooth-app that referenced this issue May 12, 2022
@cli1005
fix: openfoodfacts#1698 - refactoring
131ad95
g123k pushed a commit that referenced this issue May 12, 2022
@cli1005
fix: #1698 - layout page analytics (#1802)
e135c19 
* fix: #1698 - layout page analytics

* fix: #1698 - refactoring code review

* fix: #1698 - refactoring
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 12, 2022
@g123k g123k moved this to Done in 🎨 UXR & Design team May 12, 2022
@github-actions github-actions bot mentioned this issue May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
🎨 Mockup required 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🎯 P1
Projects
🎨 UXR & Design team
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: #1698 - layout page analytics cli1005/smooth-app
3 participants
@teolemon @bhattabhi013 @cli1005