-
-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…2465) What: * added language and country to query product list keys * that means that if I run a query for "pizza", not only the results will be different depending on the language and country (that was already the case), but the results will be cached accordingly - if I change language or country, I will see the cached results for those new language/country, not the results of the same query but with different language/country * we needed that improvement in order to display correctly the "world" results; that was the first step * also moved all the "query" classes to a specific folder * fun fact: there are more "pizza"s in France than in Italy Impacted files: * `abstract_onboarding_data.dart`: minor refactoring * `barcode_product_query.dart`: moved; minor refactoring * `category_product_query.dart`: moved; added language and country to product list key * `continuous_scan_model.dart`: minor refactoring * `country_selector.dart`: minor refactoring * `database_product_list_supplier.dart`: minor refactoring * `keywords_product_query.dart`: moved; added language and country to product list key * `main.dart`: minor refactoring * `new_product_page.dart`: minor refactoring * `nutrition_page_loaded.dart`: minor refactoring * `ocr_helper.dart`: minor refactoring * `onboarding_data_product.dart`: minor refactoring * `ordered_nutrients_cache.dart`: minor refactoring * `paged_product_query.dart`: moved; added language and country to product list key; refactored around `getProducts` * `paged_search_product_query.dart`: moved; refactored * `paged_to_be_completed_product_query.dart`: moved; added language and country to product list key; refactored * `paged_user_product_query.dart`: moved; added language to product list key; refactored * `picture_capture_helper.dart`: minor refactoring * `product_dialog_helper.dart`: minor refactoring * `product_list.dart`: added optional language and country to constructor parameters * `product_list_import_export.dart`: minor refactoring * `product_list_page.dart`: minor refactoring * `product_list_supplier.dart`: minor refactoring * `product_query.dart`: moved; not an interface anymore * `product_query_model.dart`: minor refactoring * `product_query_page_helper.dart`: minor refactoring * `product_refresher.dart`: minor refactoring * `query_product_list_supplier.dart`: minor refactoring * `robotoff_insight_helper.dart`: minor refactoring * `robotoff_questions_query.dart`: moved; minor refactoring * `search_page.dart`: minor refactoring * `simple_input_page_helpers.dart`: minor refactoring * `summary_card.dart`: minor refactoring * `user_preferences_account.dart`: minor refactoring * `user_preferences_dev_mode.dart`: minor refactoring
- Loading branch information
1 parent
3d46da9
commit 9e253a7
Showing
38 changed files
with
201 additions
and
134 deletions.
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/smooth_app/lib/data_models/abstract_onboarding_data.dart
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
packages/smooth_app/lib/database/paged_search_product_query.dart
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
packages/smooth_app/lib/pages/preferences/paged_to_be_completed_product_query.dart
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.