feat: add autocomplete in search bar #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kout95
force-pushed
the
154-filter-suggestions
branch
2 times, most recently
from
a9636c3
to
a004023
Compare
Kout95
force-pushed
the
154-filter-suggestions
branch
from
4e89c98
to
2a9dd68
Compare
Kout95
changed the title
Kout95
changed the title
Kout95
changed the title
Kout95
changed the title
alexgarel
requested changes
Jun 19, 2024
frontend/src/utils/taxonomies.ts
Outdated
Comment on lines
5
to
7
| export const getTaxonomyName = (taxonomy: string): string => { | ||
| return `${taxonomy}`.replace('s_tags', '').replace('ies_tags', 'y'); | ||
| return `${taxonomy}`.replace('ies_tags', 'y').replace('s_tags', ''); | ||
| }; |
There was a problem hiding this comment.
It should not be deduced this way, it's brittle and very specific to current configuration.
We have to open a ticket to make it better. I think the best would be for the developer to specify suggestion source in the component, or we make a specific API point for the facet suggestion that seeks for right completion in the configuration.
Comment on lines
+76
to
+77
| * Handle the input event | ||
| * It will update the query and call the getTaxonomiesTerms method to show suggestions |
Co-authored-by: Alex Garel <[email protected]>
# Conflicts: # frontend/README.md # frontend/src/search-a-licious.ts
alexgarel
reviewed
Jun 20, 2024
Comment on lines
+121
to
+123
| return document.querySelectorAll( | ||
| `searchalicious-facets[search-name=${this.name}]` | ||
| ); |
There was a problem hiding this comment.
This might not work with default name, but I will fix this with a commit before testing.
|
@Kout95 FYI I added a small commit with a very small refactor. |
alexgarel
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Part of