-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NOVA 4 attribute and knowledge panel improvements #11035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 31 out of 51 changed files in this pull request and generated no suggestions.
Files not reviewed (20)
- lib/ProductOpener/Attributes.pm: Language not supported
- lib/ProductOpener/KnowledgePanels.pm: Language not supported
- po/common/common.pot: Language not supported
- po/common/en.po: Language not supported
- po/common/fr.po: Language not supported
- templates/api/knowledge-panels/health/ingredients/nova.tt.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-attribute-groups-fr.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-attribute-groups.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-fields-all-knowledge-panels.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-fields-attribute-groups-all-knowledge-panels.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-fields-knowledge-panels-knowledge-panels_excluded-environment_card.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card.json: Language not supported
- tests/integration/expected_test_results/api_v2_product_read/get-knowledge-panels.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-attribute-groups-fr.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-attribute-groups.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-fields-all-knowledge-panels.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-fields-attribute-groups-all-knowledge-panels.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-fields-knowledge-panels-knowledge-panels_excluded-environment_card.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card.json: Language not supported
- tests/integration/expected_test_results/api_v3_product_read/get-knowledge-panels.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/update_tests_results |
Quality Gate passedIssues Measures |
Changes that were recommended by scientists for the U-TRANS study that will use the OFF app: