Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NOVA 4 attribute and knowledge panel improvements #11035

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Nov 22, 2024

Changes that were recommended by scientists for the U-TRANS study that will use the OFF app:

  • Added the number of ultra-processing markers for NOVA 4 directly in the NOVA 4 attribute description, to make it easier to differentiate foods that are slightly ultra-processed (e.g. just one flavour) and very ultra-processed with many markers
  • Added a recommendation to limit the consumption of NOVA 4 foods. Currently a bit hidden inside the NOVA knowledge panel, but we could decide to display it higher (without needing to open the NOVA panel) like we do for alcohol.

image

image

@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Attributes https://wiki.openfoodfacts.org/Product_Attributes 🧪 integration tests 🌐 Translations labels Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 31 out of 51 changed files in this pull request and generated no suggestions.

Files not reviewed (20)
  • lib/ProductOpener/Attributes.pm: Language not supported
  • lib/ProductOpener/KnowledgePanels.pm: Language not supported
  • po/common/common.pot: Language not supported
  • po/common/en.po: Language not supported
  • po/common/fr.po: Language not supported
  • templates/api/knowledge-panels/health/ingredients/nova.tt.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-attribute-groups-fr.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-attribute-groups.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-fields-all-knowledge-panels.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-fields-attribute-groups-all-knowledge-panels.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-fields-knowledge-panels-knowledge-panels_excluded-environment_card.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card.json: Language not supported
  • tests/integration/expected_test_results/api_v2_product_read/get-knowledge-panels.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-attribute-groups-fr.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-attribute-groups.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-fields-all-knowledge-panels.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-fields-attribute-groups-all-knowledge-panels.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-fields-knowledge-panels-knowledge-panels_excluded-environment_card.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card.json: Language not supported
  • tests/integration/expected_test_results/api_v3_product_read/get-knowledge-panels.json: Language not supported
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-gom
Copy link
Contributor

As discussed in the Product Opener meeting is we might want to consider using the "chips" approach proposed by Ben to show simplified details of "sub" panels at the top level, e.g.

image

@github-actions github-actions bot added API READ All READ APIs include Product, Search… API v3 labels Nov 27, 2024
@stephanegigandet
Copy link
Contributor Author

/update_tests_results

Copy link

sonarcloud bot commented Nov 28, 2024

@stephanegigandet stephanegigandet merged commit 9048011 into main Nov 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API READ All READ APIs include Product, Search… API v3 API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Attributes https://wiki.openfoodfacts.org/Product_Attributes 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations
Development

Successfully merging this pull request may close these issues.

4 participants