fix: Always update product for redis events #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Gomersall <[email protected]>
Signed-off-by: John Gomersall <[email protected]>
john-gom
changed the title
| if ( | ||
| source !== ProductSource.FULL_LOAD && | ||
| source === ProductSource.INCREMENTAL_LOAD && | ||
| lastModified?.getTime() === previousLastModified?.getTime() |
There was a problem hiding this comment.
Could you use last_updated_t instead of last_modified_t? last_updated_t is also changed when update_all_products.pl reanalyzes the product
There was a problem hiding this comment.
I've made the changes. More files affected but mostly renaming columns
Signed-off-by: John Gomersall <[email protected]>
… data from later transactions on a full import Signed-off-by: John Gomersall <[email protected]>
…ther tests Signed-off-by: John Gomersall <[email protected]>
Signed-off-by: John Gomersall <[email protected]>
Merged
john-gom
added a commit
that referenced
this pull request
Oct 31, 2024
…for-redis-events fix: Re-implement changes from PR #104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Always import product updates for events. Also switch to using last_updated_t from Product Opener for incremental bulk imports
Fixes bug(s)