Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create a product if needed after a redis update event #622

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: create a product if needed after a redis update event #622

merged 2 commits into from
Dec 12, 2024

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Dec 12, 2024 •
edited
Loading

We didn't create a product when the product was missing.

Also:

  • add unit tests to process_update
  • use production redis to listen to update: as Open Prices uses production OFF as backend, it makes sense to use the same.

@github-actions github-actions bot added the GitHub Actions Pull requests that update GitHub Actions code label Dec 12, 2024
@raphael0202 raphael0202 merged commit 66010fe into main Dec 12, 2024
10 checks passed
@raphael0202 raphael0202 deleted the fix-redis-event branch December 12, 2024 10:46
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 12, 2024
Merged
@raphodn raphodn linked an issue Dec 12, 2024 that may be closed by this pull request
Product sync: use OFF's Redis stream to get live updates #620
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@raphael0202 raphael0202

Labels
GitHub Actions Pull requests that update GitHub Actions code Product data sync
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Product sync: use OFF's Redis stream to get live updates
2 participants
@raphael0202 @raphodn