Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(location): store OSM address country_code #296

Merged
merged 2 commits into from
May 20, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented May 20, 2024

What

New field Location.osm_address_country_code

Fill it when the location is fetched from OSM

@raphodn raphodn linked an issue May 20, 2024 that may be closed by this pull request
@raphodn raphodn merged commit 43485ed into main May 20, 2024
7 checks passed
@raphodn raphodn deleted the raphodn/location-osm-address-country-code branch May 20, 2024 15:23
@monsieurtanuki
Copy link

Thank you @raphodn!

I've just tested on TEST and PROD.
Several remarks around /api/v1/locations/$locationId

  • the country code field is returned in TEST but is null - is it planned to refresh the existing prices locations with the OSM country codes?
  • the country code field is not returned in PROD - when will it be available in PROD?

@raphodn
Copy link
Member Author

raphodn commented May 20, 2024

It'll be available in prod when we release a new version, maybe tomorrow or wednesday !

And I plan to refresh existing location data points yes :)

@raphodn
Copy link
Member Author

raphodn commented May 21, 2024

Script to update the existing location data : see https://github.com/openfoodfacts/open-prices/wiki/Useful-scripts#update-locations

ran in prod on 21/05/2024 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants