feat: new Product.categories_tags array field #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/product-categories-tags-array-field
branch
2 times, most recently
from
b81ad2f to
51a84ea
Compare
raphodn
commented
Feb 9, 2024
| @@ -38,6 +38,7 @@ def init_sentry(sentry_dsn: str | None, integrations: list[Integration] | None = | |||
| "product_name", | |||
| "product_quantity", | |||
| "product_quantity_unit", | |||
| "categories_tags", | |||
There was a problem hiding this comment.
@raphael0202 need your input : I added the field in the OFF sync, but i was wondering if we should get the raw data or filter it a bit (for instance only keep the en: categories ?
example : https://world.openfoodfacts.org/api/v2/product/8001505005592.json
"categories_tags":["en:breakfasts","en:spreads","en:sweet-spreads","fr:pates-a-tartiner","en:hazelnut-spreads","en:chocolate-spreads","en:cocoa-and-hazelnuts-spreads"]
There was a problem hiding this comment.
Sorry I missed this comment. I think we can add all categories, some categories don't start with en: and are however valid categories with respect to the category taxonomy.
There was a problem hiding this comment.
Ok, but what is the default behavior ? If there is an english translation, is the category stored as en: by default ? Or can there be both en & non en categories ?
raphodn
force-pushed
the
raphodn/product-categories-tags-array-field
branch
from
51a84ea to
d470e66
Compare
raphodn
force-pushed
the
raphodn/product-categories-tags-array-field
branch
from
d470e66 to
4bcf817
Compare
This was referenced Feb 15, 2024
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
New
Product.categories_tagsfield.Why ?
Will be useful for searching/filtering/comparing in the frontend
Extra info
server_default="{}"? see https://stackoverflow.com/questions/30933266/empty-array-as-postgresql-array-column-default-value