Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price: add new "consumption-related" field on receipts: receipt_quantity #499

Closed
2 of 3 tasks
raphodn opened this issue Oct 5, 2024 · 1 comment · Fixed by #498 or #666
Closed
2 of 3 tasks

Price: add new "consumption-related" field on receipts: receipt_quantity #499

raphodn opened this issue Oct 5, 2024 · 1 comment · Fixed by #498 or #666
Labels
Personal data

Comments

@raphodn
Copy link
Member

raphodn commented Oct 5, 2024 •
edited
Loading

Story

Linked with #387

Allow users to input the number bought for a given item.

Say in a receipt I buy 2x Snickers, I will add its price once, but I want to store somewhere the info that it was bought in a larger quantity. This would rather be stored on the Price model. For instance receipt_quantity. Defaults to 1.

Todo

Frontend integration: see openfoodfacts/open-prices-frontend#974
@raphodn raphodn mentioned this issue Oct 18, 2024
Merged
@raphodn raphodn linked a pull request Oct 21, 2024 that will close this issue
feat(Prices): new field to allow users to input the quantity bought #498
Merged
@raphodn raphodn moved this from Backlog to In progress in 💸 Open Prices Oct 21, 2024
This was referenced Oct 21, 2024
Closed
Open
raphodn added a commit that referenced this issue Oct 22, 2024
@raphodn
refactor(GDPR): Use new Price.receipt_quantity field. ref #499
64fcd80
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Oct 22, 2024
Merged
@raphodn raphodn mentioned this issue Jan 1, 2025
Merged
@raphodn
Copy link
Member Author

raphodn commented Jan 1, 2025 •
edited
Loading

In #666 I made a change to the field type. We now allow users to store Decimal numbers.
Why? For "raw category" prices, for instance buying 2.5 kg of bananas.

See also openfoodfacts/open-prices-frontend#1090

@raphodn raphodn closed this as completed Jan 1, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in 💸 Open Prices Jan 1, 2025
@raphodn raphodn linked a pull request Jan 1, 2025 that will close this issue
refactor(Prices): transform receipt_quantity field to Decimal #666
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Personal data
Projects
💸 Open Prices
Status: Done
Milestone
No milestone
1 participant
@raphodn