Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof: manage new consumption-related fields (Receipt upload form, Proof display) #974

Closed
4 tasks done
raphodn opened this issue Oct 21, 2024 · 2 comments · Fixed by #973, #977, #976, #1076 or #1128
Closed
4 tasks done

Proof: manage new consumption-related fields (Receipt upload form, Proof display) #974

raphodn opened this issue Oct 21, 2024 · 2 comments · Fixed by #973, #977, #976, #1076 or #1128
Labels
Personal data Price addition 📷 Proofs

Comments

@raphodn
Copy link
Member

raphodn commented Oct 21, 2024 •
edited
Loading

Story

Following new "consumption-related" fields added to the backend : openfoodfacts/open-prices#387 & openfoodfacts/open-prices#499
--> manage them in the frontend

Todo
@raphodn raphodn linked a pull request Oct 21, 2024 that will close this issue
refactor(Proof add): rename ProofDateCurrencyInputRow to ProofMetadataInputRow #973
Merged
This was referenced Oct 21, 2024
Closed
Open
@raphodn raphodn moved this from Backlog to In progress in 💸 Open Prices Oct 21, 2024
This was linked to pull requests Oct 21, 2024
feat(Proof card): show new consumption-related fields in the footer #977
Merged
feat(Proof add): add new consumption-related fields to the form #976
Merged
@raphodn raphodn linked a pull request Dec 4, 2024 that will close this issue
refactor(Price add): show receipt personal data in already added prices footer #1076
Merged
@raphodn raphodn mentioned this issue Dec 4, 2024
Open
11 tasks
@raphodn
Copy link
Member Author

raphodn commented Dec 4, 2024

some ideas on how the "Price quantity" field input could look like

Image

@serpico serpico mentioned this issue Dec 6, 2024
Closed
@raphodn raphodn mentioned this issue Dec 14, 2024
Merged
@raphodn raphodn linked a pull request Dec 14, 2024 that will close this issue
feat(Price add): simple "quantity bought" field (only for receipt proofs) #1128
Merged
raphodn added a commit that referenced this issue Dec 14, 2024
@raphodn
refactor(Price add): avoid raising validation error for optional fiel…
ca865b1 
…ds. More compact display for receipt-only fields. ref #974
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Dec 14, 2024
Merged
@raphodn
Copy link
Member Author

raphodn commented Dec 14, 2024 •
edited
Loading

@serpico finally added the missing "quantity bought" field in #1128. will be deployed soon.

Image

closing this issue, but feel free to give feedback here after you've started using it !
and haven't forgotten #1090

@raphodn raphodn closed this as completed Dec 14, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in 💸 Open Prices Dec 14, 2024
@serpico serpico mentioned this issue Jan 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Personal data Price addition 📷 Proofs
Projects
💸 Open Prices
Archived in project
Milestone
No milestone
1 participant
@raphodn