Add/update tests

openfoodfacts · Dec 6, 2024 · 0724910 · 0724910
1 parent 335f849
commit 0724910
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/open_prices/prices/factories.py b/open_prices/prices/factories.py
@@ -40,3 +40,4 @@ class Params:
     )
     location_osm_type = factory.fuzzy.FuzzyChoice(location_constants.OSM_TYPE_LIST)
     date = date.fromisoformat("2023-10-30")
+    # owner = factory.Faker("user_name")
diff --git a/open_prices/prices/tests.py b/open_prices/prices/tests.py
@@ -358,7 +358,14 @@ def test_price_proof_validation(self):
             currency="EUR",
             owner=user_session.user.user_id,
         )
-        proof_2 = ProofFactory()
+        proof_gdpr = ProofFactory(
+            type=proof_constants.TYPE_GDPR_REQUEST,
+            location_osm_id=169450062,
+            location_osm_type=location_constants.OSM_TYPE_NODE,
+            date="2024-10-01",
+            currency="EUR",
+        )
+        proof_price_tag = ProofFactory(type=proof_constants.TYPE_PRICE_TAG)
         # proof not set
         PriceFactory(proof_id=None, owner=user_proof_receipt.owner)
         # proof unknown
@@ -374,16 +381,26 @@ def test_price_proof_validation(self):
             currency=user_proof_receipt.currency,
             owner=user_proof_receipt.owner,
         )
-        # different price & proof owner
+        # difference price and proof owner: raise a ValidationError
+        # if the proof type is different than PRICE_TAG
         self.assertRaises(
             ValidationError,
             PriceFactory,
-            proof_id=proof_2.id,  # different
+            proof_id=proof_gdpr.id,  # gdpr proof
+            location_osm_id=proof_gdpr.location_osm_id,
+            location_osm_type=proof_gdpr.location_osm_type,
+            date=proof_gdpr.date,
+            currency=proof_gdpr.currency,
+            owner=user_proof_receipt.owner,  # different owner
+        )
+        # different price & proof owner: ok for PRICE_TAG proofs
+        PriceFactory(
+            proof_id=proof_price_tag.id,
             location_osm_id=user_proof_receipt.location_osm_id,
             location_osm_type=user_proof_receipt.location_osm_type,
             date=user_proof_receipt.date,
             currency=user_proof_receipt.currency,
-            owner=user_proof_receipt.owner,
+            owner=user_proof_receipt.owner,  # different owner
         )
         # proof location_osm_id & location_osm_type
         self.assertRaises(

diff --git a/open_prices/proofs/factories.py b/open_prices/proofs/factories.py
@@ -18,6 +18,7 @@ class Meta:
     # date = factory.Faker("date")
     # currency = factory.Faker("currency_symbol")
     # price_count = factory.LazyAttribute(lambda x: random.randrange(0, 100))
+    # owner = factory.Faker("user_name")
 
 
 class ProofPredictionFactory(DjangoModelFactory):