test(simulations): improve simulation builder doc

openfisca_core/entities/types.py

@@ -4,7 +4,6 @@
 from typing import NewType, Protocol
 from typing_extensions import Required, TypedDict
 
-from openfisca_core import types
 from openfisca_core import types as t
 
 # Entities
@@ -31,12 +30,11 @@ class SingleEntity(t.SingleEntity, Protocol):
     ...
 
 
-class GroupEntity(types.CoreEntity, Protocol):
+class GroupEntity(t.GroupEntity, Protocol):
     ...
 
 
-class Role(types.Role, Protocol):
-    max: int | None
+class Role(t.Role, Protocol):
     subroles: Iterable[Role] | None
 
 

openfisca_core/simulations/_build_from_variables.py

@@ -8,7 +8,7 @@
 from openfisca_core import errors
 
 from ._build_default_simulation import _BuildDefaultSimulation
-from ._guards import is_variable_dated
+from ._guards import is_a_dated_value, is_a_pure_value
 from .simulation import Simulation
 from .types import Populations, TaxBenefitSystem, Variables
 
@@ -142,7 +142,7 @@ def add_dated_values(self) -> Self:
         """
 
         for variable, value in self.variables.items():
-            if is_variable_dated(dated_variable := value):
+            if is_a_dated_value(dated_variable := value):
                 for period, dated_value in dated_variable.items():
                     self.simulation.set_input(variable, period, dated_value)
 
@@ -200,7 +200,7 @@ def add_undated_values(self) -> Self:
         """
 
         for variable, value in self.variables.items():
-            if not is_variable_dated(undated_value := value):
+            if is_a_pure_value(undated_value := value):
                 if (period := self.default_period) is None:
                     message = (
                         "Can't deal with type: expected object. Input "