New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK import should be correct order #127

Closed

adriantam opened this issue Jun 9, 2023 · 1 comment

Labels

good first issue python-sdk

Member

adriantam commented Jun 9, 2023 •

edited

Loading

As per openfga/python-sdk#24, the python SDKs client.py library imports library in the wrong order.

As per PEP 8, the import should be in order of

Standard library imports.
Related third party imports.
Local application/library specific imports.

Furthermore, it may be good to have clean up the import so that we only import what is needed (openfga/python-sdk#23).

The file in question is https://github.com/openfga/sdk-generator/blob/main/config/clients/python/template/client/client.mustache

adriantam mentioned this issue

Styling: standard library should be imported before custom library openfga/python-sdk#24

Closed

adriantam added good first issue python-sdk labels

Member Author

adriantam commented Jun 9, 2023

Close in favour of #126

adriantam closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment