Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling: standard library should be imported before custom library #24

Closed
Tracked by #126
adriantam opened this issue Jun 9, 2023 · 0 comments · Fixed by #56
Closed
Tracked by #126

Styling: standard library should be imported before custom library #24

adriantam opened this issue Jun 9, 2023 · 0 comments · Fixed by #56
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers styling Issues related to code styling/best practices

Comments

@adriantam
Copy link
Member

adriantam commented Jun 9, 2023

Currently, the client/client.py imports custom libraries before the standard libraries as per PEP 8 style. The order should be

  1. Standard library imports.
  2. Related third party imports.
  3. Local application/library specific imports.

Furthermore, it may be good to have clean up the import so that we only import what is needed (#23).

Ideally, we will also fix the SDK generator so that newly generated python SDKs will have the corresponding changes. The corresponding SDK generator issue is openfga/sdk-generator#126. However, if that is difficult to do, simply focusing on the Python SDK side https://github.com/openfga/python-sdk/blob/main/openfga_sdk/client/client.py will help us as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers styling Issues related to code styling/best practices
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant