Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: list users announcement #731

Merged
merged 9 commits into from
May 6, 2024
Merged

chore: list users announcement #731

merged 9 commits into from
May 6, 2024

Conversation

miparnisari
Copy link
Member

No description provided.

willvedd
willvedd reviewed Apr 29, 2024
View reviewed changes
blog/list-users-announcement.md Outdated Show resolved Hide resolved
blog/list-users-announcement.md Outdated Show resolved Hide resolved
blog/list-users-announcement.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-06 19:15 UTC

@miparnisari miparnisari marked this pull request as ready for review May 1, 2024 23:16
@miparnisari miparnisari requested review from a team as code owners May 1, 2024 23:16
aaguiarz
aaguiarz requested changes May 2, 2024
View reviewed changes
blog/list-users-announcement.md Outdated Show resolved Hide resolved
blog/list-users-announcement.md Show resolved Hide resolved
@miparnisari miparnisari requested a review from aaguiarz May 3, 2024 02:55
aaguiarz
aaguiarz requested changes May 6, 2024
View reviewed changes
Copy link
Member

@aaguiarz aaguiarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to publish the docs page together with this?

If not, let's link to the API Docs..

blog/list-users-announcement.md Outdated Show resolved Hide resolved
blog/list-users-announcement.md Outdated Show resolved Hide resolved
blog/list-users-announcement.md Outdated Show resolved Hide resolved
@miparnisari miparnisari force-pushed the list-users-release branch from 698bd1d to 5674cdc Compare May 6, 2024 16:33
@miparnisari
Copy link
Member Author

Are we going to publish the docs page together with this?
If not, let's link to the API Docs..

#732 is in draft, so for now i'm linking to API docs.

@miparnisari miparnisari requested a review from aaguiarz May 6, 2024 17:49
@miparnisari miparnisari enabled auto-merge (squash) May 6, 2024 18:45
@adriantam
Copy link
Member

Just to confirm, for the image did you use git lfs?

@miparnisari
Copy link
Member Author

@adriantam not sure what you mean by that. I have git lfs set locally but how does that change my PR?

@miparnisari miparnisari merged commit c1c6fb7 into main May 6, 2024
12 checks passed
@miparnisari miparnisari deleted the list-users-release branch May 6, 2024 19:13
@adriantam
Copy link
Member

@adriantam not sure what you mean by that. I have git lfs set locally but how does that change my PR?

Just to make sure image file is using LFS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd left review comments

@nick-gagliardi nick-gagliardi nick-gagliardi approved these changes

@aaguiarz aaguiarz aaguiarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miparnisari @adriantam @aaguiarz @willvedd @nick-gagliardi