Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust some remaining css properties from new swagger-ui version #581

Merged
merged 1 commit into from
Dec 5, 2023
Merged

chore: adjust some remaining css properties from new swagger-ui version #581

merged 1 commit into from
Dec 5, 2023

Conversation

sozua
Copy link
Contributor

@sozua sozua commented Dec 4, 2023

Description

This PR resolves remaining style problems following the update to the new swagger-ui version (#579, #580) by implementing some adjustments in CSS.

1. Background color from response

old_response
new_response

2. Scheme selector

old_schemes
new_schemes

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@sozua sozua requested a review from a team as a code owner December 4, 2023 23:05
rhamzeh
rhamzeh approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sozua!

@rhamzeh rhamzeh merged commit c742ca1 into openfga:main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sozua @rhamzeh