chore(lint): add values.schema.json validation strict #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
additionalProperties: false
to the top levelvalues.schema.json
specification so that we avoid introducing new values into thevalues.yaml
file without having explicit documentation for it.As part of ☝️ it was brought to my attention that we didn't have some of the common Helm chart values specified in the
values.schema.json
, so coverage has been added for those undocumented values.References
Added entries for the top-level subchart properties to the
values.schema.json
file so we can doadditionalProperties: false
and still pass the Helm linter. See helm/helm#10392 for more info.Review Checklist
main