Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow use of custom image for wait-for-migration initContainer #80

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

marlenekoh
Copy link
Contributor

Description

Allow custom images to be used for the wait-for-migration initContainer. This is because we sometimes want to use private repos/images.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@marlenekoh marlenekoh changed the title Allow use of custom image for wait-for-migration initContainer feat: allow use of custom image for wait-for-migration initContainer Nov 5, 2023
@marlenekoh marlenekoh requested a review from a team as a code owner November 8, 2023 00:35
@marlenekoh marlenekoh force-pushed the migrations-custom-image branch 3 times, most recently from 149ac31 to 149566c Compare November 9, 2023 00:33
@marlenekoh marlenekoh force-pushed the migrations-custom-image branch from 149566c to fee6f40 Compare November 9, 2023 00:37
@miparnisari miparnisari requested a review from jpadilla November 9, 2023 04:44
@rhamzeh rhamzeh merged commit 9aedafe into openfga:main Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants