Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow new datastore implementation to be used #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grimly
Copy link

@grimly grimly commented Jan 2, 2025

This PR removes the limitations of engines to use by OpenFGA.

Description

The /datastore/engine property get its enumeration restriction removed. Additionally, a description is added to document some engines are supported.

Enables the addition to OpenFGA of a new engine without the requirement of maintaining this chart again to use it.

DOES NOT add full support for additional engines as it will be the responsibility of the chart user to add the necessary configuration (ie: does not manages persistence of a sqlite file storage)

References

Fixes #171 by allowing the use of the sqlite engine name.
This cancelled PR ( openfga/openfga#2005 ) adds support for MSSQL, if this support is added later on, it would also benefit from this PR.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@grimly grimly requested review from a team as code owners January 2, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart does not support SQLite
1 participant