feat: configure datastore username and password separately #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chart currently only support setting the datastore URI through values or secret. We deploy postgres using an operator that creates secrets with credentials and want to be able to feed username and password through the secret.
Goals of this PR:
deployment
andjob
both use them)Working example in our case, using zalando operator to create postgres cluster, the zalando operator creates a secret in the openfga namespace with credentials:
In this PR I have mimicked how the uriSecret functions in that it uses a hard coded reference key (
uri
,username
andpassword
). This is already being used to deploy openfga on our development server.But I would actually propose to change how uriSecret works similar to bitnami charts, with a configurable secret key:
This would be setup like so:
This way you can mix and match values from config and from secrets by setting the reference keys.
Description
References
Review Checklist
main
If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)