-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include "extraEnvVars" as part of the migration job #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oscmage
changed the title
Replicate deployment behaviour
Include "extraEnvVars" as part of the migration job
May 22, 2024
Oscmage
commented
May 22, 2024
ewanharris
changed the title
Include "extraEnvVars" as part of the migration job
feat: include "extraEnvVars" as part of the migration job
May 28, 2024
ewanharris
previously approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewanharris Make sense, thanks! |
Resolved merge conflict due to other changes. |
rhamzeh
previously approved these changes
Jun 3, 2024
@Oscmage please don't forget to bump the |
jon-whit
previously approved these changes
Jun 3, 2024
jon-whit
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From reading the code I see no way of providing the same
extraEnvVars
as done to the deployment for the migration job. The only way I can see is to directly adddatastore.uri
as part of the values file which is not something we want since it is a secret and something we want to commit to a git repository. It is from what I've found (please correct me if so) not possible to to use something like ExternalSecret to load the value dynamically rather than hardcoding it in the values file.I'd like to be able to do something like
We are currently running this version of the chart in production and it works just fine.
but it is currently not picked up by the migration job.
References
How it is done in the deployment file:
helm-charts/charts/openfga/templates/deployment.yaml
Line 326 in 40ea4e1
Review Checklist
main