Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prism): add conditions tokens #176

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(prism): add conditions tokens #176

merged 1 commit into from
Nov 8, 2023

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Nov 5, 2023

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh requested a review from a team as a code owner November 5, 2023 14:11
@rhamzeh rhamzeh force-pushed the feat/tokenize-conditions-in-prismjs branch from a224f90 to 48c2635 Compare November 5, 2023 15:02
d-jeffery
d-jeffery approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@d-jeffery d-jeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny detail, but otherwise LGTM

src/tools/prism/language-definition.ts Show resolved Hide resolved
@rhamzeh rhamzeh added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit a6eaf26 Nov 8, 2023
14 checks passed
@rhamzeh rhamzeh deleted the feat/tokenize-conditions-in-prismjs branch November 8, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

@d-jeffery d-jeffery d-jeffery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhamzeh @d-jeffery @adriantam