Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tuple): model id is only accepted on import and write #126

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(tuple): model id is only accepted on import and write #126

merged 1 commit into from
Aug 9, 2023

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Aug 9, 2023 •
edited
Loading

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh requested a review from a team as a code owner August 9, 2023 22:16
aaguiarz
aaguiarz approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@aaguiarz aaguiarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhamzeh rhamzeh added this pull request to the merge queue Aug 9, 2023
Merged via the queue into main with commit e038b31 Aug 9, 2023
14 checks passed
@rhamzeh rhamzeh deleted the fix/tuple-model-id-only-for-import-write branch August 9, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaguiarz aaguiarz aaguiarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhamzeh @aaguiarz