Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how and when we fetch and parse namespace info #1409

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

Waterdrips
Copy link
Contributor

Description

The initial namespace select implementation had some challenges, especially around non-default installs (no openfaas-fn namespace)
This has removed lots of those issues and added some more user friendly bits too (defaulting to first returned namespace from backend, passing that namespace to the function-create as default)

Signed-off-by: Alistair Hey [email protected]

Motivation and Context

How Has This Been Tested?

kubernetes:
Install with 4 active namespaces, switching works, adding a fn works (for each namespace)
Can add the same fn to each namespace
Can call each fn, see it calls correct one in logs
Can delete functions

Swarm:
No NS selector, can create, call and delete fns.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Waterdrips Waterdrips force-pushed the fix-ns-issues-dropdown branch from c5c78dc to 39ff7e9 Compare December 18, 2019 08:16
@alexellis alexellis merged commit 59b7839 into openfaas:master Dec 19, 2019
@alexellis
Copy link
Member

Merging based upon review from @LucasRoesler

@Waterdrips Waterdrips deleted the fix-ns-issues-dropdown branch December 19, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace selector does not update the function list
3 participants