Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Namespace indicator on Function page part of #1379 #1380

Merged

Conversation

Waterdrips
Copy link
Contributor

Description

This is a precursor to adding a dropdown for namespaces
selection (#1379)

Signed-off-by: Alistair Hey [email protected]

Motivation and Context

How Has This Been Tested?

Deployed a self-built gateway (built using make, and push.sh) to my OF installation (by updating the deployment and checking it deployed my image)

Functions load, new namespace indicator is on the function detail page (see screenshot)
Screenshot 2019-11-20 at 08 48 43

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

alexellis
alexellis previously approved these changes Nov 25, 2019
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis
Copy link
Member

Please run a rebase.

This is a precursor to adding a dropdown for namespaces
selection (openfaas#1379)

Signed-off-by: Alistair Hey <[email protected]>
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 2f683ba into openfaas:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants