Allow log requests to specify a namespace filter #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Add `Namespace` field to the log request and response so that users can specify the namespace of the function. This is required to support the new multi-namespace support. Using this, a user can deploy a function with the same name to multiple namespaces. E.g. to `dev` and `prod` namespaces. The namespace field is required so that the user can target the specific deployment of the function. It is expected the that the empty namespace will be treated as "in the default namespace" Note that this does not actually implement any filtering logic, it only allows the log providers to accept and return the information. faas-provider and log-provider implementation will need to update and handle the new field accordingly. Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler
commented
Dec 15, 2019
| @@ -103,12 +103,6 @@ func Test_GETRequestParsing(t *testing.T) { | |||
| err: "", | |||
| expectedRequest: Request{Name: "foobar"}, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This test was a copy/paste duplicate of the one above it. I probably accidentally included it during the initial implementation
|
Does this require any testing? |
|
All it does is add a new field to the jsonnand because it is a new field, it is backwards compatible. The query string parsing of the new field is already tested with the modified unit test |
|
I'll take that as a no/already covered. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
Namespacefield to the log request and response so that userscan specify the namespace of the function. This is required to
support the new multi-namespace support. Using this, a user can
deploy a function with the same name to multiple namespaces. E.g. to
devandprodnamespaces. The namespace field is required so thatthe user can target the specific deployment of the function. It is
expected the that the empty namespace will be treated as "in the
default namespace"
Note that this does not actually implement any filtering logic, it
only allows the log providers to accept and return the information.
faas-provider and log-provider implementation will need to update
and handle the new field accordingly.
Resolves #30
Supports openfaas/faas-netes#511
Signed-off-by: Lucas Roesler [email protected]