-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] multiple namespace support #511
Comments
This is required to list namespaces as part of #511. The default namespace is matched, and any additional namespaces must be annotated with the "openfaas" label. This is to prevent kube-system, etc from being used. Tested e2e with k3s/k8s 1.15 - the default ns showed, a new ns was created and annotated, which then showed up in the results subsequently. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
This is required to list namespaces as part of #511. The default namespace is matched, and any additional namespaces must be annotated with the "openfaas" label. This is to prevent kube-system, etc from being used. Tested e2e with k3s/k8s 1.15 - the default ns showed, a new ns was created and annotated, which then showed up in the results subsequently. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
This is being added for #511, so that the list, update, delete and read endpoints all can take an optional namespace override. Tested with k3s 1.15 and two namespaces. Also tested that kube- system is blocked for those commands. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
This is being added for #511, so that the list, update, delete and read endpoints all can take an optional namespace override. Tested with k3s 1.15 and two namespaces. Also tested that kube- system is blocked for those commands. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
I will work on updating faas-netes to make secrets API namespace aware and add namespace flag to the secrets command to CLI. |
hey @viveksyngh, I'm working on the would u like to focus on the CLI? for the what do u think? |
I have a POC working locally already, will cleanup and push today :) |
I think that should be fine. Please let me know if you need any help. I can work on the CLI. |
Here's the PRs from the Secrets: ❤️ |
This commit adds namespace in function names while logging metrics to prometheus, irrespective of the function is invoked with namespace suffix or not. This is also required to add multiple namespace support to faas-idler https://github.com/openfaas-incubator/faas-idler/issues/37 which is part of openfaas/faas-netes#511 Signed-off-by: Vivek Singh <[email protected]>
This commit adds namespace in function names while logging metrics to prometheus, irrespective of the function is invoked with namespace suffix or not. This is also required to add multiple namespace support to faas-idler https://github.com/openfaas-incubator/faas-idler/issues/37 which is part of openfaas/faas-netes#511 Signed-off-by: Vivek Singh <[email protected]>
This commit adds namespace in function names while logging metrics to prometheus, irrespective of the function is invoked with namespace suffix or not. This is also required to add multiple namespace support to faas-idler openfaasltd/faas-idler#37 which is part of openfaas/faas-netes#511 Signed-off-by: Vivek Singh <[email protected]>
Feature: multiple namespace support
The feature is outlined at #433, which can be used for comments, questions, and suggestions.
The use-case is: multiple namespaces, single installation, i.e.
dev/staging
,team-a/team-b
,client-a/client-b
.Checklist:
.
in paths for faas-provider Allow "." in function name faas-provider#26.
in paths for faas/gateway Allow dot in function name faas#1315CLI
Deploy via
--namespace
for single functionDeploy via stack.yml with multiple functions - Add namespace field to the stack.yml schema faas-cli#737
UI [Feature] Namespace selector in UI faas#1379
UI - add namespace selector
UI - add "all namespaces" option
Secrets
Logs
Docs
Triggers
OpenFaaS operator
Copy approach/changes from faas-netes https://github.com/openfaas-incubator/openfaas-operator/issues/92
Basic logs
Endpoint load-balancing
Multiple-namespace support
Diagram
Test out the patches so far
Test e2e with this Gist and the following patches: https://gist.github.com/alexellis/3b285ca0952d4cef48ca5dbff7e4e288
The text was updated successfully, but these errors were encountered: