Skip to content

Commit

Permalink
refactor: addressing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mariajgrimaldi committed Jul 28, 2021
1 parent abe4ee5 commit 5c1fbca
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ Unreleased
~~~~~~~~~~
Added
_____
* Add tooling needed to create and trigger events in Open edX platform
* Add tooling needed to create and trigger events in Open edX platform.
* Add Data Attribute classes used as arguments by Open edX Events.


[0.2.0] - 2021-07-28
Expand Down
15 changes: 7 additions & 8 deletions openedx_events/learning/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class UserNonPersonalData:
"""

id = attr.ib(type=int)
is_active = attr.ib(type=bool, default=True)
is_active = attr.ib(type=bool)


@attr.s(frozen=True)
Expand All @@ -41,19 +41,18 @@ class UserPersonalData:


@attr.s(frozen=True)
class UserData:
class UserData(UserNonPersonalData):
"""
Attributes defined for Open edX user object.
This class extends UserNonPersonalData to include PII data completing the
user object.
Arguments:
user_non_pii (UserNonPersonalData): user's Personal Identifiable
Information.
user_pii (UserPersonalData): user's Non Personal Identifiable
Information.
pii (UserPersonalData): user's Personal Identifiable Information.
"""

user_non_pii = attr.ib(type=UserNonPersonalData)
user_pii = attr.ib(type=UserPersonalData)
pii = attr.ib(type=UserPersonalData)


@attr.s(frozen=True)
Expand Down
2 changes: 0 additions & 2 deletions requirements/test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ django==2.2.24
# via
# -c requirements/constraints.txt
# -r requirements/base.txt
ddt==1.4.2
# via -r requirements/test.in
edx-opaque-keys[django]==2.2.2
# via -r requirements/base.txt
iniconfig==1.1.1
Expand Down

0 comments on commit 5c1fbca

Please sign in to comment.