Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action Auto Update Using Dependabot #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beingfaisal
Copy link

No description provided.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 11, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @beingfaisal!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 requested a review from a team December 3, 2024 22:31
@mphilbrick211
Copy link

Hi @openedx/committers-frontend! Would someone be able to take a look at this? The author's CLA is all set, so the tests should run green.

@bradenmacdonald
Copy link

bradenmacdonald commented Dec 4, 2024

@beingfaisal @mphilbrick211 LGTM. I'm just wondering if there is some issue/document/description/slack message /etc describing the overall plan here? I have seen this code work on other repos, so it makes sense to me, but I know some of the other upgrade bots like renovate are configured separately and in such cases it's better not to have the configuration in each repo like this. I just want to make sure someone has checked and determined this (opening a PR to add the file to each repo) is the best approach.

@brian-smith-tcril
Copy link
Contributor

I'm just wondering if there is some issue/document/description/slack message /etc describing the overall plan here?

I am also curious about this

in such cases it's better not to have the configuration in each repo like this

Even in cases with the file living in each repo, they are generally managed via repo-checks and https://github.com/openedx/.github iirc.

@feanil do you know anything about these dependabot PRs?

@bradenmacdonald
Copy link

@brian-smith-tcril Hmm, looks like an expanded version of this actually is in that repo: https://github.com/openedx/.github/blob/master/.github/dependabot.yml

Does that mean we don't need it here as well, or does that mean it's best practice and should be copied here?

@feanil
Copy link
Contributor

feanil commented Dec 5, 2024

We're doing this as a part of openedx/repo-tools#386

The reason that it's not using repo-checks is because some repos are using the file to also keep other dependencies up-to-date and others aren't so this is to just start getting github actions updated without having to solve for that at the same time.

@brian-smith-tcril
Copy link
Contributor

We're doing this as a part of openedx/repo-tools#386

The reason that it's not using repo-checks is because some repos are using the file to also keep other dependencies up-to-date and others aren't so this is to just start getting github actions updated without having to solve for that at the same time.

Thanks for the context!

@beingfaisal would you mind updating the description on this PR and similar GH Action dependabot PRs to link back to the repo-tools issue?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! It'll be great to keep all the actions up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

6 participants