-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action Auto Update Using Dependabot #86
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @beingfaisal! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @openedx/committers-frontend! Would someone be able to take a look at this? The author's CLA is all set, so the tests should run green. |
@beingfaisal @mphilbrick211 LGTM. I'm just wondering if there is some issue/document/description/slack message /etc describing the overall plan here? I have seen this code work on other repos, so it makes sense to me, but I know some of the other upgrade bots like renovate are configured separately and in such cases it's better not to have the configuration in each repo like this. I just want to make sure someone has checked and determined this (opening a PR to add the file to each repo) is the best approach. |
I am also curious about this
Even in cases with the file living in each repo, they are generally managed via repo-checks and https://github.com/openedx/.github iirc. @feanil do you know anything about these dependabot PRs? |
@brian-smith-tcril Hmm, looks like an expanded version of this actually is in that repo: https://github.com/openedx/.github/blob/master/.github/dependabot.yml Does that mean we don't need it here as well, or does that mean it's best practice and should be copied here? |
We're doing this as a part of openedx/repo-tools#386 The reason that it's not using repo-checks is because some repos are using the file to also keep other dependencies up-to-date and others aren't so this is to just start getting github actions updated without having to solve for that at the same time. |
Thanks for the context! @beingfaisal would you mind updating the description on this PR and similar GH Action dependabot PRs to link back to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! It'll be great to keep all the actions up to date!
No description provided.