feat: hotfix to post-submit page for new ida #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 94.29% 94.31% +0.02%
==========================================
Files 68 68
Lines 1086 1090 +4
Branches 299 302 +3
==========================================
+ Hits 1024 1028 +4
Misses 57 57
Partials 5 5 ☔ View full report in Codecov by Sentry. |
rijuma
reviewed
Nov 7, 2024
Comment on lines
12
to
+15
| case ExamType.PROCTORED: | ||
| return <VerifiedProctoredExamInstructions />; | ||
| case ExamType.PRACTICE: | ||
| return <VerifiedProctoredExamInstructions />; |
There was a problem hiding this comment.
Nit: Just for clarity, this could be written as:
Suggested change
| case ExamType.PROCTORED: | |
| return <VerifiedProctoredExamInstructions />; | |
| case ExamType.PRACTICE: | |
| return <VerifiedProctoredExamInstructions />; | |
| case ExamType.PRACTICE: | |
| case ExamType.PROCTORED: | |
| return <VerifiedProctoredExamInstructions />; |
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/COSMO-530
After completing a Practice Proctoring exam with an LTI provider. Reloading the page or navigating to the Dashboard and back to the exam an emtpy-ish page is shown instead of the usual landing.
I found that this is due to us not having a component that loads for Practice Exams for attempts in the "verified" or "rejected" state. I copied over the Verified/RejectedProctoredExamInstructions components to be loaded in the case that the exam's type is
PRACTICE& we're using the new exams ida as a hotfix.