Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9791] Add segment event to track the selected value for "Learning Type" dropdown #415

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Nov 22, 2024

Ticket:
https://2u-internal.atlassian.net/browse/ENT-9791

Description
This PR adds a segment event to track the selected value from the learning type dropdown. This change is required for monitoring audience engagement with videos as part of feedback evaluation.

The event name and payload will be structured as follows:

Event Name: edx.enterprise.learner_portal.catalog_search.learning_type_selected
Payload: { learningType: 'course' }

The possible learning types are:

  • course
  • program
  • learnerpathway
  • video
  • any

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Follow the release steps in the README documentation. Verify Lerna's release commit (e.g., chore(release): publish new versions) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions is on master (Important: ensure the Git tags are for the correct commit SHA).
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9791 branch 2 times, most recently from 69ac85f to 7e33925 Compare November 25, 2024 09:21
@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-9791 branch 2 times, most recently from 18bca7f to ce4c4af Compare November 25, 2024 10:07
@mahamakifdar19 mahamakifdar19 merged commit 10e2c35 into master Nov 25, 2024
4 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9791 branch November 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants