Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pathways from customers search #366

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Dec 20, 2023

Jira Ticket

We use a hardcoded list for Learning Type facet dropdown. This PR has new logic to block showing pathways on enterprise customers where the 'enablePathways' boolean is false.

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

@kiram15 kiram15 requested a review from a team December 20, 2023 22:02
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8129aae) 78.31% compared to head (ad9d2a5) 78.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   78.31%   78.37%   +0.06%     
==========================================
  Files          34       34              
  Lines         664      666       +2     
  Branches      170      170              
==========================================
+ Hits          520      522       +2     
  Misses        131      131              
  Partials       13       13              
Files Coverage Δ
...ages/catalog-search/src/LearningTypeRadioFacet.jsx 90.00% <100.00%> (+1.11%) ⬆️
packages/catalog-search/src/SearchFilters.jsx 75.00% <100.00%> (ø)
packages/catalog-search/src/SearchHeader.jsx 92.30% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8129aae...ad9d2a5. Read the comment docs.

@kiram15 kiram15 merged commit d4625c9 into master Jan 2, 2024
9 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-8123 branch January 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants