Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated frontend-build & frontend-platform major versions #932

Merged
merged 15 commits into from
May 22, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Dec 4, 2023

Description
Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages

@justinhynes
Copy link
Contributor

@BilalQamar95 Is this something you are currently still working on? If not, can we close this draft PR until it's prioritized again?

@BilalQamar95
Copy link
Contributor Author

@justinhynes I'm waiting on #415 to be reviewed and merged, once merged I will be update and open this PR for review

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.82%. Comparing base (a255bbe) to head (d15a181).
Report is 23 commits behind head on master.

Current head d15a181 differs from pull request most recent head 1a25a43

Please upload reports for the commit 1a25a43 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #932      +/-   ##
==========================================
+ Coverage   66.78%   66.82%   +0.03%     
==========================================
  Files          51       52       +1     
  Lines         849      850       +1     
  Branches      176      176              
==========================================
+ Hits          567      568       +1     
  Misses        272      272              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 changed the title Bilalqamar95/jest v29 upgrade feat: updated frontend-build & frontend-platform major versions Apr 23, 2024
@BilalQamar95 BilalQamar95 self-assigned this Apr 23, 2024
@abdullahwaheed abdullahwaheed marked this pull request as ready for review April 30, 2024 16:57
@justinhynes
Copy link
Contributor

Hey @BilalQamar95 -- any chance you can fix up the conflicts on this one too? I'll try and get it reviewed and merged right after. Thanks :)

@BilalQamar95
Copy link
Contributor Author

Hey @BilalQamar95 -- any chance you can fix up the conflicts on this one too? I'll try and get it reviewed and merged right after. Thanks :)

@justinhynes I have resolved the conflicts, PR is ready for review. Thank you for your help getting this reviewed/merged

@justinhynes justinhynes merged commit ee89125 into master May 22, 2024
7 checks passed
@justinhynes justinhynes deleted the bilalqamar95/jest-v29-upgrade branch May 22, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants