Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jwesson/fix target link #914

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

jsnwesson
Copy link
Contributor

Add a fix to make the social media links in Profile Plugin redirect the parent frame.

Copy link

@cdeery cdeery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f03d5af) 63.66% compared to head (f669d3c) 63.66%.
Report is 5 commits behind head on aperture/PluginPOCFeature.

Files Patch % Lines
src/index.jsx 0.00% 2 Missing ⚠️
src/profile/ProfilePluginPage.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           aperture/PluginPOCFeature     #914   +/-   ##
==========================================================
  Coverage                      63.66%   63.66%           
==========================================================
  Files                             54       54           
  Lines                            856      856           
  Branches                         161      161           
==========================================================
  Hits                             545      545           
  Misses                           301      301           
  Partials                          10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson jsnwesson merged commit b665d38 into aperture/PluginPOCFeature Nov 14, 2023
8 of 9 checks passed
@jsnwesson jsnwesson deleted the jwesson/fix-target-link branch November 14, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants