Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace injected /Plugins directory with lib dependency #909

Closed

Conversation

jsnwesson
Copy link
Contributor

Context:
Now that the openedx/frontend-plugin-framework exists, we want to replace the /plugin folder that was placed in the root of Profile POC.

Changes:

  • removed /plugin directory
  • added @edx/frontend-plugin-framework#{open_PR_branch} to package.json

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f03d5af) 63.66% compared to head (d598cf1) 63.66%.
Report is 4 commits behind head on aperture/PluginPOCFeature.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           aperture/PluginPOCFeature     #909   +/-   ##
==========================================================
  Coverage                      63.66%   63.66%           
==========================================================
  Files                             54       54           
  Lines                            856      856           
  Branches                         161      161           
==========================================================
  Hits                             545      545           
  Misses                           301      301           
  Partials                          10       10           
Files Coverage Δ
src/profile/ProfilePluginPage.jsx 0.00% <ø> (ø)
src/index.jsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes
Copy link
Contributor

Hi @jsnwesson,

This has been open since November. Is this PR still needed? Should someone on the team be reviewing it? If not, can we close it? Or make it a draft?

@jsnwesson
Copy link
Contributor Author

@justinhynes thanks for bringing this up! Nope, it can be closed since we're not continuing with the PluginPOC feature branch for the time being. I'll close it out.

@jsnwesson jsnwesson closed this Jan 8, 2024
@justinhynes justinhynes deleted the jwesson/insert-plugins-dependency branch January 8, 2024 19:48
@justinhynes justinhynes restored the jwesson/insert-plugins-dependency branch January 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants